kazuyukitanimura commented on code in PR #581:
URL: https://github.com/apache/datafusion-comet/pull/581#discussion_r1643604445
##########
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -46,25 +41,14 @@ trait ShimCometScanExec {
.map { a => a.setAccessible(true); a }
.flatMap(_.invoke(wrapped).asInstanceOf[Seq[AttributeReference]])
- // TODO: remove after dropping Spark 3.2 and 3.3 support and directly call
+ // TODO: remove after dropping Spark 3.3 support and directly call
Review Comment:
nit `metadataColumns` is still needed for Spark 3.3 but we can update the
comment
##########
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -74,7 +58,7 @@ trait ShimCometScanExec {
options: ParquetOptions): FileScanRDD =
classOf[FileScanRDD].getDeclaredConstructors
// Prevent to pick up incorrect constructors from any custom Spark forks.
- .filter(c => List(3, 5, 6).contains(c.getParameterCount()) )
+ .filter(c => List(3, 5, 6).contains(c.getParameterCount()))
.map { c =>
c.getParameterCount match {
case 3 => c.newInstance(fsRelation.sparkSession, readFunction,
filePartitions)
Review Comment:
We should be able to remove the `case 3`
##########
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -93,7 +77,7 @@ trait ShimCometScanExec {
.last
.asInstanceOf[FileScanRDD]
- // TODO: remove after dropping Spark 3.2 and 3.3 support and directly call
+ // TODO: remove after dropping Spark 3.3 support and directly call
// QueryExecutionErrors.SparkException
protected def invalidBucketFile(path: String, sparkVersion: String):
Throwable = {
if (sparkVersion >= "3.3") {
Review Comment:
This if condition can be removed as it should be always true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
