jonahgao commented on PR #11036:
URL: https://github.com/apache/datafusion/pull/11036#issuecomment-2182995239
> so i think the only way to fix that issue is to return a `u64`, which will
alter the API.
@LorrensP-2158466 How about returning an overflow error when the final
result cannot fit into `i64`? This way, it won't cause an API change. Something
like this:
```rust
i64::try_from(a << shift).map_err(|_| exec_datafusion_err!("Overflow in
gcd"))
```
I think we could have a separate fix for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
