xinlifoobar commented on code in PR #11068:
URL: https://github.com/apache/datafusion/pull/11068#discussion_r1649972435
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -1449,8 +1420,14 @@ mod tests {
// column c1
let c1_stats = &stats.column_statistics[0];
assert_eq!(c1_stats.null_count, Precision::Exact(1));
- assert_eq!(c1_stats.max_value, Precision::Absent);
- assert_eq!(c1_stats.min_value, Precision::Absent);
Review Comment:
The test behaviour changes due to Utf8 is not supported in
https://github.com/apache/datafusion/blob/ea21b08e477cc48f458917c132f79c4980c957c1/datafusion/core/src/datasource/file_format/parquet.rs#L298-L376
##########
datafusion/core/src/datasource/physical_plan/parquet/statistics.rs:
##########
@@ -873,7 +921,7 @@ impl<'a> StatisticsConverter<'a> {
let mut builder = UInt64Array::builder(10);
for metadata in metadatas.into_iter() {
- let row_count = metadata.num_rows();
+ let row_count = metadata.total_byte_size();
Review Comment:
Don't trust this diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
