jayzhan211 commented on PR #11013: URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2186686180
> There seems to be a column added to the Aggregate node in the logical plan, can that affect performance and/or memory footprint? This was the reason why I didn't update the test in the first place > > This is a subset of the new plan > > ``` > aggr=[[sum(test.c) AS alias2, MAX(test.b) AS alias3]] [a:UInt32, alias1:UInt32, alias2:UInt64;N, alias3:UInt32;N]\n TableScan: test [a:UInt32, b:UInt32, c:UInt32]" > ``` > > while this is the subset from the previous plan > > ``` > Aggregate: groupBy=[[test.a, test.b AS alias1]], aggr=[[sum(test.c) AS alias2]] [a:UInt32, alias1:UInt32, alias2:UInt64;N]\n TableScan: test [a:UInt32, b:UInt32, c:UInt32]" > ``` > > there is an alias3:UInt64 that gets added Remove the Min/Max matching in `is_single_distinct_agg` and the alias is removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
