alamb commented on issue #11193: URL: https://github.com/apache/datafusion/issues/11193#issuecomment-2200205905
I think the usecase of passing some sort of state to `TableProvider` methods is a good and useful thing https://docs.rs/datafusion/latest/datafusion/datasource/provider/trait.TableProvider.html One way is to add a `SessionState` parameter as you suggest to all the methods. Given that it is already passed to `scan`, this seems a pretty reasonable change to me. While it would be an API change it would be very mechanical to add. However, it seems like if we ever are going to break apart the core crate more, we'll have to figure out how to split out SessionContext. We have a related discussion here: https://github.com/apache/datafusion/issues/11182 Also related slack coversation in ASF slack: https://the-asf.slack.com/archives/C04RJ0C85UZ/p1719691754005389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
