jonahgao commented on PR #11256: URL: https://github.com/apache/datafusion/pull/11256#issuecomment-2209124848
I think there might be a simpler way to achieve this. We can declare the count aggregation expr as non-nullable like [this](https://github.com/apache/datafusion/commit/21d01196d8e76ad6df145e378c755af528569b0e), and then the simplify_expressions rule and the eliminate_filter rule will handle subsequent processing. https://github.com/apache/datafusion/blob/6e637488188c6620ecd113bf47987bd98f6d7871/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L1450-L1454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
