jonahgao commented on code in PR #11267:
URL: https://github.com/apache/datafusion/pull/11267#discussion_r1665830815
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -237,7 +237,11 @@ impl ExprSchemable for Expr {
Expr::Like { .. } | Expr::SimilarTo { .. } =>
Ok(DataType::Boolean),
Expr::Placeholder(Placeholder { data_type, .. }) => {
data_type.clone().ok_or_else(|| {
- plan_datafusion_err!("Placeholder type could not be
resolved. Make sure that the placeholder is bound to a concrete type, e.g. by
providing parameter values.")
+ plan_datafusion_err!(
Review Comment:
This is the actual change; the others are made by `cargo fmt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]