Blizzara opened a new pull request, #11277:
URL: https://github.com/apache/datafusion/pull/11277
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
Substrait uses the name "substring", and it already exists in DF SQL
## What changes are included in this PR?
Adds "substring" alias for "substr" UDF so that it can be found from
Substrait consumer. Also adds a mapping into Substrait producer to rewrite
"substr" into "substring".
And fixes the substr roundtrip test.
The setup here is a bit weird; in unicode.mod there is a "substring" udf
being created so that it can be used in `export_functions` with different args
than the "substr" version, even if both really end up using the same `substr`
impl. What's the use for the `export_functions` versions? Anyways I think
that's unrelated to this PR.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes - fixed (*) the Substrait roundtrip test for SUBSTR and confirmed it
uses the correct alias:
`ExtensionFunction { extension_uri_reference: 4294967295, function_anchor:
0, name: "substring" }`
DF doesn't validate the functions against the Substrait extensions so we
don't automatically check that the name is correct, but this should be good
enough.
*: The previous version would optimize the call away already during
planning, so the Substrait actually didn't contain the substr call, just an
equals check. Now it does. There are a bunch more functions where that happens,
I didn't want to fix everything here but may do it as a followup!
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
