alamb commented on code in PR #11283:
URL: https://github.com/apache/datafusion/pull/11283#discussion_r1666765835
##########
datafusion/physical-expr/src/equivalence/ordering.rs:
##########
@@ -556,9 +556,9 @@ mod tests {
let eq_group = EquivalenceGroup::new(eq_group);
eq_properties.add_equivalence_group(eq_group);
- let constants = constants.into_iter().map(|expr| {
- ConstExpr::new(Arc::clone(expr)).with_across_partitions(true)
- });
+ let constants = constants
+ .into_iter()
+ .map(|expr|
ConstExpr::from(expr).with_across_partitions(true));
Review Comment:
I think this change makes it easier to follow the logic here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
