alamb commented on code in PR #11273:
URL: https://github.com/apache/datafusion/pull/11273#discussion_r1666794239
##########
datafusion/expr/src/planner.rs:
##########
@@ -133,6 +133,17 @@ pub trait UserDefinedSQLPlanner: Send + Sync {
fn plan_extract(&self, args: Vec<Expr>) ->
Result<PlannerResult<Vec<Expr>>> {
Ok(PlannerResult::Original(args))
}
+
+ fn plan_create_struct(&self, args: Vec<Expr>) ->
Result<PlannerResult<Vec<Expr>>> {
Review Comment:
Could we please document these functions on the traits
I think it would be especially useful to document what the arguments meant,
and how the arguments between create_struct and create_named_struct differ
Perhaps we can lift the documentation from
https://datafusion.apache.org/user-guide/sql/scalar_functions.html#struct and
https://datafusion.apache.org/user-guide/sql/scalar_functions.html#named-struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
