alamb commented on code in PR #11297: URL: https://github.com/apache/datafusion/pull/11297#discussion_r1667353718
########## datafusion/sqllogictest/test_files/cast.slt: ########## @@ -69,3 +69,16 @@ query ? SELECT CAST(MAKE_ARRAY() AS VARCHAR[]) ---- [] + +statement ok +create table t0(v0 BIGINT); + +statement ok +insert into t0 values (1),(2),(3); + +query I +select * from t0 where v0>1e100; +---- + Review Comment: I suggest a test that also shows the filter passing (I wasn't sure if the whole thing was turned into NULL). But I double checked and this query works on this branch: ```suggestion query I select * from t0 where v0<1e100; ---- 1 2 3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
