jonahgao commented on PR #11307: URL: https://github.com/apache/datafusion/pull/11307#issuecomment-2212872927
I think aliases in a predicate will not affect functionality. They are just useless because they do not contribute to the output names of the filter plan, nor will any other expressions reference them. If this is true, we can move the [unalias](https://github.com/apache/datafusion/blob/main/datafusion/expr/src/logical_plan/plan.rs#L662) logic to `Filter::try_new` and convert this check to a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
