alamb commented on code in PR #11368:
URL: https://github.com/apache/datafusion/pull/11368#discussion_r1671238011
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -91,14 +88,14 @@ impl FilterExec {
Ok(Self {
predicate,
- input: input.clone(),
+ input: Arc::clone(&input),
Review Comment:
This was causing clippy failures on main
https://github.com/apache/datafusion/actions/runs/9857745125/job/27217695529
I think due to a logical conflict
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -369,12 +368,12 @@ pub(crate) fn batch_filter(
.and_then(|v| v.into_array(batch.num_rows()))
.and_then(|array| {
let filter_array = match as_boolean_array(&array) {
- Ok(boolean_array) => {
- Ok(boolean_array.to_owned())
- },
+ Ok(boolean_array) => Ok(boolean_array.to_owned()),
Err(_) => {
let Ok(null_array) = as_null_array(&array) else {
- return internal_err!("Cannot create filter_array from
non-boolean predicates, unable to continute");
+ return internal_err!(
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
