Rachelint commented on PR #11261: URL: https://github.com/apache/datafusion/pull/11261#issuecomment-2219043216
> > @alamb One thing I worry about the narrow api is that, it seems can't be used to support the original optimization of min/max? > > Maybe I misunderstand about it? > > No, sorry, you are correct, I was mistaken Ok... Been a bit busy the past couple of days, continue to read the related codes and think a relative good way to solve this today... One way I could think to solve it temporarily for not blocking the progress of #10943 is that we just treat it a special case like `count`: https://github.com/apache/datafusion/blob/1e0c06e14ae821ac6aa344f8acb638431a898ae8/datafusion/core/src/physical_optimizer/aggregate_statistics.rs#L144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
