waynexia commented on issue #11375: URL: https://github.com/apache/datafusion/issues/11375#issuecomment-2219471677
Compared with putting lots of logic in `lib.rs`, splitting it into several dedicated modules does make it easier to read and maintain. This kind of refactor keeps happening in our codebase which is very :rocket: and I agree we should keep doing this. The name of sub-module's root file (whether `mod.rs` or `some_func.rs`) is another pattern discussion. GreptimeDB uses `some_func.rs` instead of `mod.rs` whereas DataFusion has more `mod.rs`. This is closer to style taste and IMO has less effect on maintainability or readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
