comphead commented on code in PR #11391:
URL: https://github.com/apache/datafusion/pull/11391#discussion_r1672690447
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -138,6 +138,10 @@ impl AggregateUDFImpl for Count {
return Ok(Box::new(CountAccumulator::new()));
}
+ if acc_args.input_exprs.len() > 1 {
Review Comment:
That is correct, Spark supports it, I double checked it. Maybe it is SQL
2023 standard, but if any of dialects supports this syntax then parser is not
expected to restrict it and this PR is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
