Dandandan commented on code in PR #20055:
URL: https://github.com/apache/datafusion/pull/20055#discussion_r2740345153
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -291,6 +291,7 @@ where
// Extract length from the view (first 4 bytes of u128 in
little-endian)
let len = view_u128 as u32;
+ let value: &[u8] = values.value(i).as_ref();
Review Comment:
This is true we should avoid it to get it only when needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
