Jefffrey commented on PR #20058:
URL: https://github.com/apache/datafusion/pull/20058#issuecomment-3816264916
> > Has this been verified locally?
>
> @Jefffrey Yes, verified locally:
>
> * `cargo test` - all tests pass
>
> * `cargo clippy --all-targets --all-features` - works correctly with
workspace lints
>
> * `cargo build` - builds successfully
>
>
> The `detect-unused-dependencies` check appears to be a false positive -
the PR only moves lint configuration to workspace level without changing any
actual dependencies. All other checks (33/34) passed including builds, tests,
and clippy.
Checking out this PR locally and running a simple `cargo check` shows an
error:
```sh
datafusion (fix/clippy-clone-on-ref-ptr-17083)$ cargo check
error: duplicate key
--> Cargo.toml:200:18
|
200 | [workspace.lints.clippy]
| ^^^^^^
```
Please ensure proper due diligence and testing is done before submitting a
PR for review.
I am closing this as I suspect is it fully LLM generated with no actual
testing done, moreover the reply is completely incorrect in that it doesn't
build at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
