andygrove commented on PR #3328: URL: https://github.com/apache/datafusion-comet/pull/3328#issuecomment-3819229006
> > Are we able to use the standard .slt format or do we require additional features? There's an MIT-licensed parser from the Apache Calcite team here: https://github.com/hydromatic/sql-logic-test > > This is inspired by slt but there are some key differences. > > * We do not record expected results in the file. Instead, we compare to Spark (and we run for multiple Spark versions) > > * There are specific features to support minimum Spark version, and support settings Spark configs, including combinatorial matrices (so that we can migrate some existing tests to this approach) > > * It creates individual scala unit tests per file, fitting into the existing testing approach It is also worth pointing out that the test runner is ~300 LOC and extends `CometTestBase`, so this is tightly integrated with existing test infrastructure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
