timsaucer commented on PR #750: URL: https://github.com/apache/datafusion-python/pull/750#issuecomment-2223128481
@kylebarron I hadn't thought before about splitting up the type annotations in one place and the documentation in another. That's very clever. Also there was this comment on discord about using `pyi` files: > mypy has a great tool to validate that stubs are correct https://mypy.readthedocs.io/en/stable/stubtest.html In my mind for this project the rust code isn't necessarily "closer" to the implementation for the vast majority of what we're doing. This repo is to a large extent just exposing the `datafusion` repository features. So adding documentation here for example: ``` expr_fn!(upper, arg1, "Converts the string to all upper case."); ``` isn't particularly "closer" to the implementation of the `upper` function than putting the document string in a python wrapper. I guess it comes down to this question: Do we want to have features like in @datapythonista 's example above that we can more easily handle in the python side OR do we want this repository to focus on being python exposed rust functions and classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
