Jefffrey commented on code in PR #20049:
URL: https://github.com/apache/datafusion/pull/20049#discussion_r2744044350
##########
datafusion/functions-nested/src/repeat.rs:
##########
@@ -243,56 +240,75 @@ fn general_list_repeat<O: OffsetSizeTrait>(
list_array: &GenericListArray<O>,
count_array: &UInt64Array,
) -> Result<ArrayRef> {
- let data_type = list_array.data_type();
- let value_type = list_array.value_type();
- let mut new_values = vec![];
+ let counts = count_array.values();
Review Comment:
We might need a followup issue if this is the existing behaviour; we can't
rely on null slots being `0` value (potential bug), moreover I feel we should
be consistent with null semantics (usually a null input would return null 🤔)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
