iffyio commented on code in PR #2168:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2168#discussion_r2747751698
##########
src/parser/mod.rs:
##########
@@ -9002,7 +9002,15 @@ impl<'a> Parser<'a> {
/// [ColumnOption::NotNull].
fn parse_column_option_expr(&mut self) -> Result<Expr, ParserError> {
if self.peek_token_ref().token == Token::LParen {
- let expr: Expr = self.with_state(ParserState::Normal, |p|
p.parse_prefix())?;
+ let mut expr = self.with_state(ParserState::Normal, |p|
p.parse_prefix())?;
Review Comment:
to support the chained cast, we would consume the double colon in a loop? I
think the current approach duplicates parts of the expr parsing code most of
which aren't exactly related to the problem being solved for, which makes it
not ideal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
