alamb commented on code in PR #19728:
URL: https://github.com/apache/datafusion/pull/19728#discussion_r2748148727
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -6535,7 +6535,7 @@ async fn test_fill_null_all_columns() -> Result<()> {
async fn test_insert_into_casting_support() -> Result<()> {
// Testing case1:
// Inserting query schema mismatch: Expected table field 'a' with type
Float16, but got 'a' with type Utf8.
- // And the cast is not supported from Utf8 to Float16.
+ // And the cast is not supported from Binary to Float16.
Review Comment:
@Jefffrey added support for Utf8->Float casting in
https://github.com/apache/arrow-rs/pull/9262 so this test started failing it
expected this not to work 😆
##########
datafusion-cli/src/object_storage/instrumented.rs:
##########
@@ -453,28 +455,24 @@ impl ObjectStore for InstrumentedObjectStore {
self.inner.list_with_delimiter(prefix).await
}
- async fn copy(&self, from: &Path, to: &Path) -> Result<()> {
Review Comment:
copy and copy_if_not_exists were consolidated
##########
datafusion-cli/src/object_storage/instrumented.rs:
##########
@@ -230,40 +231,57 @@ impl InstrumentedObjectStore {
let timestamp = Utc::now();
let range = options.range.clone();
+ let head = options.head;
Review Comment:
A substantial amount of the changes in tis PR are due to the upgrade to
object_store 0.13 where several of the trait methods are consolidated (e.g.
`get`, `get_opts`, `head`, etc) have been consolidated.
You can see the upgrade guide here
https://github.com/apache/arrow-rs-object-store/blob/8ef1aaa9cad5699971de1173d16637d01795da6e/src/lib.rs#L698-L736
Sadly, the docs.rs page is broken, and I have filed a ticket for that:
- https://github.com/rust-lang/docs.rs/issues/3173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
