sqlbenchmark commented on PR #1431:
URL: 
https://github.com/apache/datafusion-ballista/pull/1431#issuecomment-3829500007

   ## Ballista Criterion Benchmark Results
   
   **PR:** #1431 - fix: add missing batch_size argument to benchmark
   **PR Commit:** `89699c7`
   **Base Commit:** `4fe9e1d` (main)
   **Bench:** sort_shuffle
   
   ### Main branch
   
   ```
   .9.34+deprecated
     Downloaded serde_derive_internals v0.29.1
     Downloaded schemars_derive v0.8.22
     Downloaded rustls-pki-types v1.14.0
     Downloaded prettyplease v0.2.37
     Downloaded datafusion-physical-expr-common v52.1.0
     Downloaded datafusion-functions-nested v52.1.0
     Downloaded rustls-pemfile v2.2.0
     Downloaded pin-project v1.1.10
     Downloaded form_urlencoded v1.2.2
     Downloaded datafusion-proto-common v52.1.0
     Downloaded ring v0.17.14
     Downloaded zerofrom v0.1.6
     Downloaded yoke-derive v0.8.1
     Downloaded want v0.3.1
     Downloaded generic-array v0.14.7
     Downloaded foldhash v0.1.5
     Downloaded futures-timer v3.0.3
     Downloaded displaydoc v0.2.5
     Downloaded pbjson-build v0.8.0
     Downloaded filetime v0.2.27
     Downloaded humantime v2.3.0
     Downloaded lazy_static v1.5.0
     Downloaded fs_extra v1.3.0
     Downloaded aws-lc-sys v0.37.0
     Downloaded nu-ansi-term v0.50.3
     Downloaded nibble_vec v0.1.0
     Downloaded ipnet v2.11.0
     Downloaded hyper-timeout v0.5.2
     Downloaded http-body-util v0.1.3
     Downloaded rustls-native-certs v0.8.3
     Downloaded parse-display-derive v0.9.1
     Downloaded time-macros v0.2.26
     Downloaded synstructure v0.13.2
     Downloaded tinystr v0.8.2
     Downloaded tracing-appender v0.2.4
     Downloaded prost-derive v0.14.3
     Downloaded hmac v0.12.1
     Downloaded httparse v1.10.1
     Downloaded hyper-rustls v0.27.7
     Downloaded liblzma v0.4.5
     Downloaded matchit v0.8.4
     Downloaded ferroid v0.8.9
     Downloaded strum_macros v0.27.2
     Downloaded toml_parser v1.0.6+spec-1.1.0
     Downloaded tempfile v3.24.0
     Downloaded pbjson-types v0.8.0
     Downloaded num-rational v0.4.2
     Downloaded litemap v0.8.1
     Downloaded icu_provider v2.1.1
     Downloaded icu_properties v2.1.2
     Downloaded indexmap v1.9.3
     Downloaded rstest v0.26.1
     Downloaded prost-build v0.14.3
     Downloaded libbz2-rs-sys v0.2.2
     Downloaded icu_normalizer_data v2.1.1
     Downloaded schemars v0.8.22
     Downloaded icu_normalizer v2.1.1
     Downloaded icu_locale_core v2.1.1
     Downloaded miniz_oxide v0.8.9
     Downloaded serde_derive v1.0.228
     Downloaded substrait v0.62.2
     Downloaded icu_collections v2.1.1
     Downloaded hyper-util v0.1.19
     Downloaded schemars v1.2.0
     Downloaded http v1.4.0
     Downloaded http v0.2.12
     Downloaded hashbrown v0.12.3
     Downloaded idna v1.1.0
     Downloaded testcontainers v0.26.3
     Downloaded itertools v0.14.0
     Downloaded iri-string v0.7.10
     Downloaded hashbrown v0.15.5
     Downloaded hashbrown v0.14.5
     Downloaded hyper v1.8.1
     Downloaded libm v0.2.16
     Downloaded datafusion-substrait v52.1.0
     Downloaded h2 v0.4.13
     Downloaded icu_properties_data v2.1.2
     Downloaded datafusion-sql v52.1.0
     Downloaded quick-xml v0.38.4
     Downloaded time v0.3.46
     Downloaded object_store v0.12.5
     Downloaded webpki-roots v1.0.5
     Downloaded object v0.32.2
     Downloaded nix v0.30.1
     Downloaded libmimalloc-sys v0.1.44
     Downloaded tracing v0.1.44
     Downloaded liblzma-sys v0.4.5
     Downloaded linux-raw-sys v0.11.0
   error: no bench target named `sort_shuffle` in default-run packages
   
   ```
   
   ### PR branch
   
   ```
   Compiling env_logger v0.11.8
      Compiling crossbeam-deque v0.8.6
      Compiling structopt v0.3.26
      Compiling ballista v52.0.0 (/app/ballista/ballista/client)
      Compiling ciborium-io v0.2.2
      Compiling plotters-backend v0.3.7
      Compiling plotters-svg v0.3.7
      Compiling ciborium-ll v0.2.2
      Compiling itertools v0.10.5
      Compiling cast v0.3.0
      Compiling criterion-plot v0.5.0
      Compiling rayon v1.11.0
      Compiling ciborium v0.2.2
      Compiling plotters v0.3.7
      Compiling tinytemplate v1.2.1
      Compiling is-terminal v0.4.17
      Compiling oorandom v11.1.5
      Compiling anes v0.1.6
      Compiling criterion v0.5.1
      Compiling ballista-benchmarks v52.0.0 (/app/ballista/benchmarks)
       Finished `bench` profile [optimized] target(s) in 6m 05s
        Running benches/sort_shuffle.rs 
(target/release/deps/sort_shuffle-b1db7a23d64cf131)
   Gnuplot not found, using plotters backend
   Benchmarking sort_shuffle_no_spill/10_batches_200_partitions
   Benchmarking sort_shuffle_no_spill/10_batches_200_partitions: Warming up for 
3.0000 s
   Benchmarking sort_shuffle_no_spill/10_batches_200_partitions: Collecting 10 
samples in estimated 8.3379 s (110 iterations)
   Benchmarking sort_shuffle_no_spill/10_batches_200_partitions: Analyzing
   sort_shuffle_no_spill/10_batches_200_partitions
                           time:   [74.878 ms 75.035 ms 75.212 ms]
   Benchmarking sort_shuffle_no_spill/50_batches_200_partitions
   Benchmarking sort_shuffle_no_spill/50_batches_200_partitions: Warming up for 
3.0000 s
   Benchmarking sort_shuffle_no_spill/50_batches_200_partitions: Collecting 10 
samples in estimated 6.7437 s (20 iterations)
   Benchmarking sort_shuffle_no_spill/50_batches_200_partitions: Analyzing
   sort_shuffle_no_spill/50_batches_200_partitions
                           time:   [334.08 ms 335.67 ms 337.27 ms]
   
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_8mb_limit
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_8mb_limit: 
Warming up for 3.0000 s
   
   Warning: Unable to complete 10 samples in 5.0s. You may wish to increase 
target time to 14.2s.
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_8mb_limit: 
Collecting 10 samples in estimated 14.171 s (10 iterations)
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_8mb_limit: 
Analyzing
   sort_shuffle_with_spill/50_batches_200_partitions_8mb_limit
                           time:   [1.3970 s 1.4203 s 1.4435 s]
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_2mb_limit
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_2mb_limit: 
Warming up for 3.0000 s
   
   Warning: Unable to complete 10 samples in 5.0s. You may wish to increase 
target time to 19.1s.
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_2mb_limit: 
Collecting 10 samples in estimated 19.112 s (10 iterations)
   Benchmarking sort_shuffle_with_spill/50_batches_200_partitions_2mb_limit: 
Analyzing
   sort_shuffle_with_spill/50_batches_200_partitions_2mb_limit
                           time:   [1.9959 s 2.0315 s 2.0692 s]
   
   
   ```
   
   ---
   *Automated benchmark run by dfbench*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to