devanshu0987 commented on PR #20059: URL: https://github.com/apache/datafusion/pull/20059#issuecomment-3830357673
> Hi @devanshu0987, I didn't have a chance to take a close look at everything, but I saw you're using unit tests instead of slt tests. I'm working on a similar issue on `date_part` function #19733, and there I only added new slt tests and no unit tests. A few of those use `EXPLAIN` to make sure the original function no longer appears in the logical and physical plans. Correctness is proved by existing floor slt tests. Although you are right, it would be a good idea to validate `EXPLAIN` output as well. I will add them to a new PR and will tag you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
