andygrove commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-ballista/pull/1435#discussion_r2751893379
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -417,6 +424,17 @@ async fn benchmark_ballista(opt: BallistaBenchmarkOpt) ->
Result<()> {
config = config.set_str(BALLISTA_SHUFFLE_SORT_BASED_ENABLED,
"true");
}
+ for kv in &opt.config_overrides {
+ if let Some((key, value)) = kv.split_once('=') {
+ config = config.set_str(key.trim(), value.trim());
+ } else {
+ return Err(DataFusionError::Configuration(format!(
Review Comment:
The check is only for malformed key-value pairs - so if the the user calls
`-c foo`, which is not a valid key-value pair then we now print a message
instead of failing. I think the current version is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
