killzoner commented on code in PR #1361:
URL:
https://github.com/apache/datafusion-ballista/pull/1361#discussion_r2751948846
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -52,6 +52,9 @@ pub(crate) use crate::state::execution_stage::{
};
use crate::state::task_manager::UpdatedStages;
+/// Boxed [ExecutionGraph]
+pub type ExecutionGraphBox = Box<dyn ExecutionGraph + Send + Sync>;
Review Comment:
Probably doesn't hurt, but wonder why we have both `Send` and `Sync` bounds,
I've seen a lot in async librabries being overly restrictive. Can be changed
later though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
