adriangb commented on code in PR #20091:
URL: https://github.com/apache/datafusion/pull/20091#discussion_r2754665919


##########
datafusion/substrait/src/logical_plan/producer/rel/read_rel.rs:
##########
@@ -97,10 +97,19 @@ pub fn from_table_scan(
     producer: &mut impl SubstraitProducer,
     scan: &TableScan,
 ) -> datafusion::common::Result<Box<Rel>> {
+    // Convert projection expressions back to indices for Substrait
+    let source_schema = scan.source.schema();

Review Comment:
   If there were any complex expressions we need to wrap w/ a projection here!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to