parthchandra commented on code in PR #3366:
URL: https://github.com/apache/datafusion-comet/pull/3366#discussion_r2755890610
##########
Makefile:
##########
@@ -65,6 +65,13 @@ ifdef HAS_OSXCROSS
cd native && cargo build -j 2 --target aarch64-apple-darwin --release
$(FEATURES_ARG)
endif
+# build native libs for Graviton architecture Linux on a Graviton
machine/container
+# Requires Rust nightly for -Z tls-model flag
+# Uses initial-exec TLS model, LSE, and native CPU optimizations for Graviton
+core-graviton-libs:
+ cd native && RUSTFLAGS="-Z tls-model=initial-exec -C
target-feature=+lse -C target-cpu=native" \
Review Comment:
The `-Z tls-model=initial-exec` flag requires `nightly`. The gain from this
change only came to about 1% so we can revert this if we don't want to use
`nightly`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
