jayzhan211 commented on PR #11361: URL: https://github.com/apache/datafusion/pull/11361#issuecomment-2224743438
Not sure is there any things else to do before merging this TODOs in the next PRs - [ ] Decide if we want to have make_map follow named_struct or if it would be better to have something more like what duckdb does - [ ] document map/make_map in the documentation. We can do this as a follow on PR: https://datafusion.apache.org/user-guide/sql/scalar_functions.html#struct-functions - [ ] Support arrays (not just scalars) I think we can simplify the two map functions to one first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
