iffyio commented on code in PR #2186:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2186#discussion_r2757825997
##########
src/parser/mod.rs:
##########
@@ -17925,9 +17925,9 @@ impl<'a> Parser<'a> {
})
}
- /// Parse a 'BEGIN' statement
- pub fn parse_begin(&mut self) -> Result<Statement, ParserError> {
- let modifier = if !self.dialect.supports_start_transaction_modifier() {
+ /// Parse a transaction modifier keyword that can follow a BEGIN statement.
+ pub fn parse_transaction_modifier(&mut self) ->
Option<TransactionModifier> {
Review Comment:
```suggestion
pub(crate) fn parse_transaction_modifier(&mut self) ->
Option<TransactionModifier> {
```
##########
src/parser/mod.rs:
##########
@@ -17925,9 +17925,9 @@ impl<'a> Parser<'a> {
})
}
- /// Parse a 'BEGIN' statement
- pub fn parse_begin(&mut self) -> Result<Statement, ParserError> {
- let modifier = if !self.dialect.supports_start_transaction_modifier() {
+ /// Parse a transaction modifier keyword that can follow a BEGIN statement.
Review Comment:
```suggestion
/// Parse a transaction modifier keyword that can follow a `BEGIN`
statement.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
