andygrove commented on PR #3355: URL: https://github.com/apache/datafusion-comet/pull/3355#issuecomment-3841787900
Hi @EmilyMatt. I agree that the code could benefit from some cleanup, but is it possible to break this down into some smaller PRs? Perhaps start with one to introduce the new trait? This is a large PR to review, and it lacks a description of the specific changes, so I'm not sure where to start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
