EmilyMatt opened a new pull request, #3374:
URL: https://github.com/apache/datafusion-comet/pull/3374
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Towards #3355
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Starts separating code so moving the partitioners out of the shuffle_writer
file will not look like a mess.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1. Moved metrics into a separate file.
2. Renamed the struct ShufflePartitionerMetrics, there is some inconsistent
use of "partitioner" and "repartitioner" throughout the module, I think
partitioner fits better since we only deal from the context of a single
partition at all times, and regardless of which variation is chosen I think
it's better to make everything uniform.
3. Moved the function that aligns the scratch space with the current
buffered batches into the ScratchSpace struct itself, it seems very logical due
to the function signature and its actual logic.
Did this mostly because it moves out a big chunk of code that was "stuck"
inside the partitioner logic itself, which will make changes there look a bit
messy.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
By the usual tests, as there is no change in logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
