comphead commented on code in PR #3378: URL: https://github.com/apache/datafusion-comet/pull/3378#discussion_r2760569768
########## docs/source/contributor-guide/parquet_scans.md: ########## @@ -37,9 +37,15 @@ implementation: - Leverages the DataFusion community's ongoing improvements to `DataSourceExec` - Provides support for reading complex types (structs, arrays, and maps) -- Removes the use of reusable mutable-buffers in Comet, which is complex to maintain +- Delegates Parquet decoding to native Rust code rather than JVM-side decoding - Improves performance +> **Note on mutable buffers:** Both `native_comet` and `native_iceberg_compat` use reusable mutable buffers Review Comment: wondering should we note changes in https://github.com/apache/datafusion-comet/pull/3367 it is not a native reusable buffer, but stating the JVM unsafe rows are copied? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
