adriangb commented on PR #20117:
URL: https://github.com/apache/datafusion/pull/20117#issuecomment-3843386076
> 🤖: Benchmark completed
>
> Details
> ```
> group
get-field-pushdown-try-3 main
> -----
------------------------ ----
> logical_aggregate_with_join 1.01 643.3±10.62µs
? ?/sec 1.00 639.4±6.12µs ? ?/sec
> logical_select_all_from_1000 1.00 10.3±0.09ms
? ?/sec 1.12 11.5±0.15ms ? ?/sec
> logical_select_one_from_700 1.01 421.7±3.89µs
? ?/sec 1.00 415.8±2.36µs ? ?/sec
> logical_trivial_join_high_numbered_columns 1.01 380.8±12.39µs
? ?/sec 1.00 376.5±3.19µs ? ?/sec
> logical_trivial_join_low_numbered_columns 1.01 365.3±4.47µs
? ?/sec 1.00 361.5±11.63µs ? ?/sec
> physical_intersection 1.00 1627.7±31.01µs
? ?/sec 1.00 1622.2±125.58µs ? ?/sec
> physical_join_consider_sort 1.02 2.3±0.05ms
? ?/sec 1.00 2.3±0.02ms ? ?/sec
> physical_join_distinct 1.01 356.9±8.17µs
? ?/sec 1.00 353.0±3.93µs ? ?/sec
> physical_many_self_joins 1.01 12.7±0.08ms
? ?/sec 1.00 12.5±0.26ms ? ?/sec
> physical_plan_clickbench_all 1.01 203.2±1.51ms
? ?/sec 1.00 200.9±1.71ms ? ?/sec
> physical_plan_clickbench_q1 1.01 2.2±0.02ms
? ?/sec 1.00 2.1±0.02ms ? ?/sec
> physical_plan_clickbench_q10 1.05 3.8±0.14ms
? ?/sec 1.00 3.7±0.10ms ? ?/sec
> physical_plan_clickbench_q11 1.04 4.3±0.09ms
? ?/sec 1.00 4.1±0.04ms ? ?/sec
> physical_plan_clickbench_q12 1.05 4.5±0.09ms
? ?/sec 1.00 4.2±0.04ms ? ?/sec
> physical_plan_clickbench_q13 1.06 4.0±0.06ms
? ?/sec 1.00 3.8±0.12ms ? ?/sec
> physical_plan_clickbench_q14 1.05 4.3±0.09ms
? ?/sec 1.00 4.1±0.04ms ? ?/sec
> physical_plan_clickbench_q15 1.04 4.0±0.07ms
? ?/sec 1.00 3.9±0.09ms ? ?/sec
> physical_plan_clickbench_q16 1.05 3.9±0.07ms
? ?/sec 1.00 3.7±0.04ms ? ?/sec
> physical_plan_clickbench_q17 1.05 4.0±0.07ms
? ?/sec 1.00 3.8±0.02ms ? ?/sec
> physical_plan_clickbench_q18 1.02 2.7±0.03ms
? ?/sec 1.00 2.7±0.02ms ? ?/sec
> physical_plan_clickbench_q19 1.02 4.3±0.12ms
? ?/sec 1.00 4.2±0.09ms ? ?/sec
> physical_plan_clickbench_q2 1.03 2.9±0.03ms
? ?/sec 1.00 2.8±0.06ms ? ?/sec
> physical_plan_clickbench_q20 1.01 2.2±0.03ms
? ?/sec 1.00 2.2±0.02ms ? ?/sec
> physical_plan_clickbench_q21 1.01 2.8±0.04ms
? ?/sec 1.00 2.8±0.05ms ? ?/sec
> physical_plan_clickbench_q22 1.04 4.1±0.07ms
? ?/sec 1.00 3.9±0.05ms ? ?/sec
> physical_plan_clickbench_q23 1.03 4.3±0.08ms
? ?/sec 1.00 4.2±0.03ms ? ?/sec
> physical_plan_clickbench_q24 1.02 4.9±0.07ms
? ?/sec 1.00 4.8±0.04ms ? ?/sec
> physical_plan_clickbench_q25 1.01 3.5±0.03ms
? ?/sec 1.00 3.5±0.09ms ? ?/sec
> physical_plan_clickbench_q26 1.02 3.0±0.06ms
? ?/sec 1.00 2.9±0.04ms ? ?/sec
> physical_plan_clickbench_q27 1.01 3.6±0.10ms
? ?/sec 1.00 3.5±0.06ms ? ?/sec
> physical_plan_clickbench_q28 1.02 4.5±0.10ms
? ?/sec 1.00 4.5±0.06ms ? ?/sec
> physical_plan_clickbench_q29 1.02 4.8±0.07ms
? ?/sec 1.00 4.7±0.04ms ? ?/sec
> physical_plan_clickbench_q3 1.02 2.6±0.03ms
? ?/sec 1.00 2.5±0.03ms ? ?/sec
> physical_plan_clickbench_q30 1.04 16.1±0.21ms
? ?/sec 1.00 15.5±0.22ms ? ?/sec
> physical_plan_clickbench_q31 1.02 4.5±0.03ms
? ?/sec 1.00 4.5±0.05ms ? ?/sec
> physical_plan_clickbench_q32 1.02 4.5±0.04ms
? ?/sec 1.00 4.5±0.04ms ? ?/sec
> physical_plan_clickbench_q33 1.02 3.7±0.09ms
? ?/sec 1.00 3.6±0.08ms ? ?/sec
> physical_plan_clickbench_q34 1.02 3.3±0.03ms
? ?/sec 1.00 3.2±0.03ms ? ?/sec
> physical_plan_clickbench_q35 1.01 3.4±0.03ms
? ?/sec 1.00 3.3±0.03ms ? ?/sec
> physical_plan_clickbench_q36 1.03 4.3±0.08ms
? ?/sec 1.00 4.2±0.04ms ? ?/sec
> physical_plan_clickbench_q37 1.02 4.7±0.09ms
? ?/sec 1.00 4.7±0.06ms ? ?/sec
> physical_plan_clickbench_q38 1.01 4.7±0.04ms
? ?/sec 1.00 4.7±0.07ms ? ?/sec
> physical_plan_clickbench_q39 1.01 4.1±0.07ms
? ?/sec 1.00 4.1±0.05ms ? ?/sec
> physical_plan_clickbench_q4 1.03 2.2±0.04ms
? ?/sec 1.00 2.2±0.02ms ? ?/sec
> physical_plan_clickbench_q40 1.01 5.0±0.05ms
? ?/sec 1.00 4.9±0.07ms ? ?/sec
> physical_plan_clickbench_q41 1.01 4.3±0.03ms
? ?/sec 1.00 4.3±0.08ms ? ?/sec
> physical_plan_clickbench_q42 1.01 4.3±0.07ms
? ?/sec 1.00 4.2±0.05ms ? ?/sec
> physical_plan_clickbench_q43 1.01 4.6±0.06ms
? ?/sec 1.00 4.5±0.06ms ? ?/sec
> physical_plan_clickbench_q44 1.01 2.3±0.08ms
? ?/sec 1.00 2.3±0.02ms ? ?/sec
> physical_plan_clickbench_q45 1.01 2.3±0.02ms
? ?/sec 1.00 2.3±0.03ms ? ?/sec
> physical_plan_clickbench_q46 1.01 3.2±0.08ms
? ?/sec 1.00 3.2±0.03ms ? ?/sec
> physical_plan_clickbench_q47 1.02 4.8±0.05ms
? ?/sec 1.00 4.7±0.07ms ? ?/sec
> physical_plan_clickbench_q48 1.00 5.2±0.06ms
? ?/sec 1.00 5.3±0.19ms ? ?/sec
> physical_plan_clickbench_q49 1.01 5.5±0.11ms
? ?/sec 1.00 5.4±0.08ms ? ?/sec
> physical_plan_clickbench_q5 1.04 2.6±0.10ms
? ?/sec 1.00 2.5±0.02ms ? ?/sec
> physical_plan_clickbench_q50 1.01 4.2±0.11ms
? ?/sec 1.00 4.2±0.04ms ? ?/sec
> physical_plan_clickbench_q51 1.01 3.6±0.08ms
? ?/sec 1.00 3.6±0.07ms ? ?/sec
> physical_plan_clickbench_q6 1.05 2.6±0.07ms
? ?/sec 1.00 2.5±0.02ms ? ?/sec
> physical_plan_clickbench_q7 1.04 2.2±0.04ms
? ?/sec 1.00 2.1±0.02ms ? ?/sec
> physical_plan_clickbench_q8 1.05 3.6±0.10ms
? ?/sec 1.00 3.5±0.03ms ? ?/sec
> physical_plan_clickbench_q9 1.04 3.8±0.09ms
? ?/sec 1.00 3.6±0.08ms ? ?/sec
> physical_plan_tpcds_all 1.00 1968.6±20.06ms
? ?/sec 1.00 1966.2±18.94ms ? ?/sec
> physical_plan_tpch_all 1.00 129.4±1.21ms
? ?/sec 1.00 129.9±1.06ms ? ?/sec
> physical_plan_tpch_q1 1.03 3.1±0.03ms
? ?/sec 1.00 3.0±0.06ms ? ?/sec
> physical_plan_tpch_q10 1.01 7.4±0.06ms
? ?/sec 1.00 7.3±0.10ms ? ?/sec
> physical_plan_tpch_q11 1.01 8.7±0.15ms
? ?/sec 1.00 8.6±0.17ms ? ?/sec
> physical_plan_tpch_q12 1.01 3.1±0.03ms
? ?/sec 1.00 3.1±0.03ms ? ?/sec
> physical_plan_tpch_q13 1.01 3.1±0.06ms
? ?/sec 1.00 3.0±0.02ms ? ?/sec
> physical_plan_tpch_q14 1.02 3.2±0.03ms
? ?/sec 1.00 3.1±0.03ms ? ?/sec
> physical_plan_tpch_q16 1.01 5.3±0.04ms
? ?/sec 1.00 5.2±0.05ms ? ?/sec
> physical_plan_tpch_q17 1.03 5.8±0.04ms
? ?/sec 1.00 5.6±0.07ms ? ?/sec
> physical_plan_tpch_q18 1.01 6.1±0.06ms
? ?/sec 1.00 6.0±0.10ms ? ?/sec
> physical_plan_tpch_q19 1.03 5.3±0.03ms
? ?/sec 1.00 5.1±0.10ms ? ?/sec
> physical_plan_tpch_q2 1.03 12.7±0.13ms
? ?/sec 1.00 12.4±0.17ms ? ?/sec
> physical_plan_tpch_q20 1.00 8.2±0.06ms
? ?/sec 1.01 8.3±0.15ms ? ?/sec
> physical_plan_tpch_q21 1.01 10.3±0.10ms
? ?/sec 1.00 10.2±0.14ms ? ?/sec
> physical_plan_tpch_q22 1.01 6.6±0.10ms
? ?/sec 1.00 6.5±0.06ms ? ?/sec
> physical_plan_tpch_q3 1.02 5.7±0.04ms
? ?/sec 1.00 5.6±0.04ms ? ?/sec
> physical_plan_tpch_q4 1.01 3.1±0.05ms
? ?/sec 1.00 3.0±0.07ms ? ?/sec
> physical_plan_tpch_q5 1.01 6.0±0.04ms
? ?/sec 1.00 6.0±0.10ms ? ?/sec
> physical_plan_tpch_q6 1.01 1617.3±16.07µs
? ?/sec 1.00 1604.1±25.37µs ? ?/sec
> physical_plan_tpch_q7 1.02 7.4±0.08ms
? ?/sec 1.00 7.2±0.12ms ? ?/sec
> physical_plan_tpch_q8 1.01 9.5±0.07ms
? ?/sec 1.00 9.3±0.09ms ? ?/sec
> physical_plan_tpch_q9 1.00 6.8±0.04ms
? ?/sec 1.00 6.8±0.10ms ? ?/sec
> physical_select_aggregates_from_200 1.00 17.7±0.13ms
? ?/sec 1.00 17.7±0.11ms ? ?/sec
> physical_select_all_from_1000 1.00 23.6±0.24ms
? ?/sec 1.05 24.7±0.17ms ? ?/sec
> physical_select_one_from_700 1.02 1357.1±8.44µs
? ?/sec 1.00 1327.1±11.77µs ? ?/sec
> physical_sorted_union_order_by_10_int64 1.02 11.3±0.09ms
? ?/sec 1.00 11.1±0.11ms ? ?/sec
> physical_sorted_union_order_by_10_uint64 1.02 30.8±0.37ms
? ?/sec 1.00 30.2±0.37ms ? ?/sec
> physical_sorted_union_order_by_50_int64 1.01 200.9±2.34ms
? ?/sec 1.00 199.8±4.52ms ? ?/sec
> physical_sorted_union_order_by_50_uint64 1.04 1148.2±7.76ms
? ?/sec 1.00 1104.5±15.61ms ? ?/sec
> physical_theta_join_consider_sort 1.07 2.8±0.02ms
? ?/sec 1.00 2.6±0.02ms ? ?/sec
> physical_unnest_to_join 1.05 3.2±0.04ms
? ?/sec 1.00 3.1±0.04ms ? ?/sec
> physical_window_function_partition_by_12_on_values 1.02 1612.1±18.59µs
? ?/sec 1.00 1587.3±11.05µs ? ?/sec
> physical_window_function_partition_by_30_on_values 1.02 3.0±0.03ms
? ?/sec 1.00 2.9±0.06ms ? ?/sec
> physical_window_function_partition_by_4_on_values 1.01 1095.9±10.86µs
? ?/sec 1.00 1085.1±20.62µs ? ?/sec
> physical_window_function_partition_by_7_on_values 1.02 1280.3±30.33µs
? ?/sec 1.00 1261.3±17.40µs ? ?/sec
> physical_window_function_partition_by_8_on_values 1.02 1347.7±7.20µs
? ?/sec 1.00 1323.7±12.37µs ? ?/sec
> with_param_values_many_columns 1.00 577.1±5.70µs
? ?/sec 1.05 606.5±14.52µs ? ?/sec
> ```
@alamb are there any of these that use structs? It seems like this has no
impact on the benchmarks (good!) but maybe we should add some that hit the full
rewrite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
