ozankabak commented on PR #11425: URL: https://github.com/apache/datafusion/pull/11425#issuecomment-2225469912
This looks good to me. I want to note the typical outlook on extension APIs we have: Extension APIs that provide "safe" default behaviors are more likely to be suitable for upstream DataFusion, while APIs that require major changes to built-in operators is less likely. Continuing on the stream processing example, supporting certain stream processing features for built-in DF operators will likely result in a performance loss for run-to-completion use cases. Therefore, we may still end up adding extension APIs to `ExecutionPlan` for such features, but most likely should leave implementation of such operators downstream. I'm not sure if we need to add such detail to the doc, but I thought leaving an example here could be helpful to future new collaborators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
