peterxcli commented on code in PR #2905:
URL: https://github.com/apache/datafusion-comet/pull/2905#discussion_r2763617744
##########
spark/src/main/scala/org/apache/comet/serde/maps.scala:
##########
@@ -89,3 +89,27 @@ object CometMapFromArrays extends
CometExpressionSerde[MapFromArrays] {
optExprWithInfo(mapFromArraysExpr, expr, expr.children: _*)
}
}
+
+object CometMapFromEntries extends
CometScalarFunction[MapFromEntries]("map_from_entries") {
Review Comment:
```suggestion
object CometMapFromEntries extends CometExpressionSerde[MapFromEntries] {
```
sorry for disrupting you, should we implement those scalar function with
inheriting `CometExpressionSerde` or, `CometScalarFunction`. just want to make
sure the standard.
cause I'm also working on some map expression support. eg. #3369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
