Copilot commented on code in PR #143:
URL: https://github.com/apache/datafusion-site/pull/143#discussion_r2763626003
##########
content/theme/templates/menu.html:
##########
@@ -1,15 +1,15 @@
<!-- nav bar -->
<nav class="navbar navbar-expand-lg navbar-dark bg-dark" aria-label="Fifth
navbar example">
<div class="container-fluid">
- <a class="navbar-brand" href="/blog"><img
src="/blog/images/logo_original4x.png" style="height: 32px;"/> Apache
DataFusion Blog</a>
+ <a class="navbar-brand" href="/blog/"><img
src="/blog/images/logo_original4x.png" style="height: 32px;"/> Apache
DataFusion Blog</a>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse"
data-bs-target="#navbarADP" aria-controls="navbarADP" aria-expanded="false"
aria-label="Toggle navigation">
<span class="navbar-toggler-icon"></span>
</button>
<div class="collapse navbar-collapse" id="navbarADP">
<ul class="navbar-nav me-auto mb-2 mb-lg-0">
<li class="nav-item">
- <a class="nav-link" href="/blog/about.html">About</a>
+ <a class="nav-link" href="./blog/about.html">About</a>
Review Comment:
Using a relative path of `./blog/about.html` here will resolve incorrectly
on pages under `/blog/` (e.g., `/blog/index.html` will link to
`/blog/blog/about.html`). This should use an absolute path like
`/blog/about.html` (or the appropriate site variable) so the About link works
correctly from all pages.
```suggestion
<a class="nav-link" href="/blog/about.html">About</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
