andygrove opened a new pull request, #3392:
URL: https://github.com/apache/datafusion-comet/pull/3392

   ## Which issue does this PR close?
   
   Closes #3315
   
   ## Rationale for this change
   
   When `native_datafusion` is enabled, several Spark SQL tests fail because 
`CometNativeScanExec`:
   1. Always returns `UnknownPartitioning` instead of preserving the original 
partitioning for bucketed scans
   2. Is not recognized in plan structure checks that look for 
`FileSourceScanExec` or `CometScanExec`
   
   ## What changes are included in this PR?
   
   1. **Fixed `CometNativeScanExec.scala`**: Updated `outputPartitioning` to 
preserve the original partitioning for bucketed scans, matching the pattern 
used by `CometScanExec`. This should fix the BroadcastJoinSuite tests that 
expected `PartitioningCollection` but got `UnknownPartitioning`.
   
   2. **Updated diff files**: Added `CometNativeScanExec` to the pattern match 
in `FileDataSourceV2FallBackSuite` for the "Fallback Parquet V2 to V1" test 
across all three diff files (3.4.3, 3.5.8, 4.0.1).
   
   ## How are these changes tested?
   
   The changes should be verified by running the Spark SQL tests with 
`native_datafusion` enabled in CI.
   
   Note: The streaming tests in `StreamingSelfUnionSuite` may need separate 
investigation if they're still failing, as they don't have explicit plan 
structure checks.
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to