mvzink commented on code in PR #2182:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2182#discussion_r2765455011
##########
src/parser/mod.rs:
##########
@@ -5309,6 +5311,26 @@ impl<'a> Parser<'a> {
None
};
+ // Parse MySQL-style [DEFAULT] CHARACTER SET and [DEFAULT] COLLATE
options
+ loop {
+ let has_default = self.parse_keyword(Keyword::DEFAULT);
+ if self.parse_keywords(&[Keyword::CHARACTER, Keyword::SET])
+ || self.parse_keyword(Keyword::CHARSET)
+ {
+ self.expect_token(&Token::Eq).ok();
+ default_charset = Some(self.parse_identifier()?.value);
+ } else if self.parse_keyword(Keyword::COLLATE) {
Review Comment:
Actually, MySQL accepts multiple collations and uses the last one. I added a
comment reflecting that, but fix the char set condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
