jayzhan211 commented on issue #11433:
URL: https://github.com/apache/datafusion/issues/11433#issuecomment-2225720653
This one looks good to me too. But, it is nice to have a case that benefit
on the nullability of the element (like the query that is optimized based on
this)
```rust
let mut fields = vec![Field::new_list(
format_state_name(self.name(), "nth_value"),
Field::new("item", args.input_type.clone(), self.nullable),
true)]
```
Otherwise for simplicity, we can assume it is nullable
```rust
let mut fields = vec![Field::new_list(
format_state_name(self.name(), "nth_value"),
Field::new("item", args.input_type.clone(), true),
true)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
