andygrove opened a new pull request, #3407: URL: https://github.com/apache/datafusion-comet/pull/3407
## Summary - Extract iceberg benchmarks from `CometReadBaseBenchmark` into new `CometIcebergReadBenchmark` object - Add `addParquetScanCases` helper to `CometBenchmarkBase` that encapsulates the repeated 3-case pattern (Spark / native_datafusion / native_iceberg_compat) used by all parquet benchmarks - Refactor `CometReadBaseBenchmark` and `CometPartitionColumnBenchmark` to use the new helper, eliminating ~270 lines of duplicated boilerplate ## Test plan - [x] `./mvnw compile test-compile -pl spark -DskipTests` passes - [x] `./mvnw spotless:check -pl spark` passes - [ ] Run `CometReadBenchmark` to verify parquet benchmarks work - [ ] Run `CometIcebergReadBenchmark` to verify iceberg benchmarks work - [ ] Run `CometPartitionColumnBenchmark` to verify partition benchmarks work 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
