andygrove commented on code in PR #3377:
URL: https://github.com/apache/datafusion-comet/pull/3377#discussion_r2770131680
##########
spark/src/test/scala/org/apache/comet/CometSqlFileTestSuite.scala:
##########
@@ -96,6 +96,20 @@ class CometSqlFileTestSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
checkSparkAnswerAndFallbackReason(sql, reason)
case Ignore(reason) =>
logInfo(s"IGNORED query (${reason}): $sql")
+ case ExpectError(pattern) =>
+ val (sparkError, cometError) =
checkSparkAnswerMaybeThrows(spark.sql(sql))
+ assert(
+ sparkError.isDefined,
+ s"Expected Spark to throw an error matching '$pattern' but
query succeeded")
+ assert(
Review Comment:
If the query is tagged with `expect_error` then we expect both Spark and
Comet to return an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
