cj-zhukov commented on PR #20122: URL: https://github.com/apache/datafusion/pull/20122#issuecomment-3859203462
> Thanks @cj-zhukov I have some feeling the `examples_docs` can be renamed to reflect it is a parser for examples, perhaps it would be good to split into smaller utility files as well. But this can be addressed in the following PR. > > One thing to note is: `nom` not very actively developing Thanks for the feedback! I agree that `examples_docs` could be renamed to better reflect that it’s focused on parsing example metadata, and that the code could be split into smaller, more focused utility modules. To keep this PR scoped and easy to review, I’d prefer to address renaming and refactoring in a follow-up PR. I’ll open one specifically for improving naming and structure. Thanks also for the note about `nom` - I’m keeping its usage minimal here so it should be easy to adjust if needed in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
