kosiew commented on issue #20165: URL: https://github.com/apache/datafusion/issues/20165#issuecomment-3859596377
Proto changes cannot be decoupled into its own PR. The proto changes have to be implemented together with CastColumnExpr as it is part of the physical expression tree, which is serialized/deserialized in datafusion-proto. Once we add a new physical expression variant or change its data model (like OwnedCastOptions, schema-aware fields, etc.), we need to update the proto layer so: 1. Plans can be serialized/deserialized correctly CastColumnExpr gets sent over the wire (or stored) when physical plans are serialized. Without proto updates, roundtrip tests fail or the plan can’t be restored. 2. Owned cast/format options now need to be preserved The new design stores options in owned Strings. That means the protobuf needs fields for PhysicalCastOptions and FormatOptions, plus the corresponding conversion logic in from_proto.rs and to_proto.rs. 3. Round-trip tests assert fidelity The roundtrip_physical_plan.rs tests exercise proto serialization, so those must be updated whenever expression structs or option handling changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
