andygrove opened a new pull request, #3437: URL: https://github.com/apache/datafusion-comet/pull/3437
## Summary - Add `CometNativeScanExec` pattern matching to `BucketedReadSuite` and `DisableUnnecessaryBucketedScanSuite` in all three Spark version diffs (3.4.3, 3.5.8, 4.0.1) - Remove `IgnoreCometNativeDataFusion(#3319)` tags from 7 tests in the 3.5.8 diff that are now expected to pass ## Details When `native_datafusion` scan mode is active, `CometNativeScanExec` replaces `FileSourceScanExec` in the query plan. The test suites already pattern-match on `CometScanExec` but not `CometNativeScanExec`, causing ~7 bucketed scan tests to fail. Changes in `BucketedReadSuite.scala`: - `getFileScan()` — match on `CometNativeScanExec` - `getBucketScan()` — match on `CometNativeScanExec` - `verify()` in bucket coalescing test — match on `CometNativeScanExec` for `optionalNumCoalescedBuckets` Changes in `DisableUnnecessaryBucketedScanSuite.scala`: - Import `CometNativeScanExec` - `checkNumBucketedScan()` — match on `CometNativeScanExec` Closes #3319 ## Test plan - [ ] Verify diffs apply cleanly to respective Spark versions - [ ] Run `BucketedReadSuite` and `DisableUnnecessaryBucketedScanSuite` with `ENABLE_COMET=true` and `native_datafusion` scan mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
