rafafrdz opened a new pull request, #3438: URL: https://github.com/apache/datafusion-comet/pull/3438
# Summary - Add native Comet support for Spark's `GetTimestamp` expression, which allow the followings, - Add native Comet support for Spark's `ParseToDate` expression, and therefore `to_date` function ( Closes #3093 ) - Add native Comet support for Spark's `ParseToTimestamp` expression, and therefore `to_timestamp` function ( Closes #3109 ) In order to add support both `to_date` and `to_timestamp` spark sql functions, we need first to cover [`GetTimestamp`](https://github.com/apache/spark/blob/5a48a37b2dbd7b51e3640cd1d947438459556cc6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L1093) as an intermediate expression within the query plan when call either [`ParseToDate`](https://github.com/apache/spark/blob/5a48a37b2dbd7b51e3640cd1d947438459556cc6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L2052) (`to_date` function) or [`ParseToTimestamp`](https://github.com/apache/spark/blob/5a48a37b2dbd7b51e3640cd1d947438459556cc6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L2127) (`to_timestamp` function). ### Note to maintainers Since this is my first contribution to Apache DataFusion Comet, I may have missed some steps in the development or contribution process. Please let me know if anything is missing or needs adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
