notashes commented on code in PR #20182:
URL: https://github.com/apache/datafusion/pull/20182#discussion_r2778164988
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -205,5 +222,123 @@ where
Arc::new(array)
}
+/// Create a StructArray with multiple columns
+fn create_struct_array(array_len: usize) -> ArrayRef {
+ let mut rng = make_rng();
+
+ // Create 4 columns of different types for our struct array
+ let bool_array: ArrayRef = Arc::new(
+ (0..array_len)
+ .map(|_| Some(rng.random::<bool>()))
+ .collect::<arrow::array::BooleanArray>(),
+ );
+
+ let int32_array: ArrayRef = Arc::new(
Review Comment:
done! and yes the benchmark numbers are pretty much the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
