zhuqi-lucas commented on code in PR #20188: URL: https://github.com/apache/datafusion/pull/20188#discussion_r2778691172
########## datafusion/datasource/src/file.rs: ########## @@ -46,6 +46,12 @@ pub fn as_file_source<T: FileSource + 'static>(source: T) -> Arc<dyn FileSource> /// file format specific behaviors for elements in [`DataSource`] /// +/// # Schema information +/// There are two important schemas for a [`FileSource`]: +/// 1. [`Self::table_schema`] -- the schema for the overall "table" Review Comment: I think it be worth explicitly noting in the table_schema() doc that it includes partition columns? e.g. "the schema for the overall table (file schema + partition columns)". The FileScanConfig docs mention this, but it's easy to miss when reading FileSource alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
