mishop-15 opened a new pull request, #20221:
URL: https://github.com/apache/datafusion/pull/20221
## Which issue does this PR close?
Closes #20219
## Rationale for this change
The DATE_BIN function was panicking when datetime operations went out of
range instead of returning proper errors. The two specific cases were:
1. Month subtraction going out of range causing `DateTime - Months` panic
2. `timestamp_nanos_opt()` returning None and then unwrapping
## What changes are included in this PR?
- Changed `date_bin_months_interval` and `to_utc_date_time` to return
`Result` instead of panicking
- Replaced `origin_date - Months` and `origin_date + Months` with
`checked_sub_months` and `checked_add_months`
- Replaced `.unwrap()` calls with proper `match` statements and error
handling
- Updated all callers throughout the file to handle `Result` types
## Are these changes tested?
Tested manually with the exact queries from the issue that were panicking:
```sql
select DATE_BIN('1637426858', TO_TIMESTAMP_MILLIS(1040292460), TIMESTAMP
'1984-01-07 00:00:00');
select DATE_BIN('1637426858', TO_TIMESTAMP_MILLIS(-1040292460), TIMESTAMP
'1984-01-07 00:00:00');
```
Both queries now return NULL instead of panicking. All existing unit tests
pass.
## Are there any user-facing changes?
Yes - queries with DATE_BIN that would previously panic now return NULL when
datetime operations go out of range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
